Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editable headline, description and overline for extra-large-promo… #2255

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

Gripholder
Copy link
Collaborator

@Gripholder Gripholder commented Oct 15, 2024

Be sure to run npm test, npm run lint, and write detailed test steps before requesting reviewers

Description

Jira Ticket: THEMES-2015

Add editable headline, description and overline for extra-large-promo-block
Screenshot 2024-10-15 at 6 13 50 AM

Test Steps

Add detailed test steps a reviewer must complete to test this PR

  1. Checkout this branch git checkout THEMES-2015
  2. Run fusion repo with linked blocks npx fusion start -f -l extra-large-promo-block
  3. Verify that the extra large promo has an editable headline, description and overline in PB Editor

@Gripholder Gripholder requested a review from a team as a code owner October 15, 2024 12:29
blakeganderson
blakeganderson previously approved these changes Nov 1, 2024
Copy link
Contributor

@blakeganderson blakeganderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blakeganderson blakeganderson merged commit 7bf9d27 into arc-themes-release-version-2.5.2 Nov 1, 2024
8 checks passed
@blakeganderson blakeganderson deleted the THEMES-2015 branch November 1, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants